[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-12-23 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-568637972 > > @AngersZh, I didn't read all fully but can we make https://issues.apache.org/jira/browse/SPARK-15694 done first as @wangy

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-11-04 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-549637273 > @alfozan > Seems you are working on https://issues.apache.org/jira/browse/SPARK-15694 > But I am confused that current Scr

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-11-01 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-548728149 Looks good! Thank you. This is an automated message from the Apa

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-11-01 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-548715130 > @alfozan > You can see my branch's newest change. and check the update Could you share a link to the new branch/PR? -

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-11-01 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-548694618 > > Another issue: > > query: > > `MAP k / 10 USING 'cat' AS (aa) from (select 10 as k); ` > > Error in query: cannot res

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-11-01 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-548692408 Another issue: query: `MAP k / 10 USING 'cat' AS (aa) from (select 10 as k); ` Error in query: cannot resolve

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-11-01 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-548691723 Here's what I mean: test query: ``` SELECT TRANSFORM(key, abs(key)) USING 'cat' FROM (SELECT DISTINCT key F

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-10-31 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-548663422 Another test query: ``` SELECT TRANSFORM(key, abs(key)) USING 'cat' FROM (SELECT DISTINCT key FROM src); ```

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-10-29 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-547368476 simpler test case: ``` FROM (select 1 as key, 100 as value) src MAP src.*, CAST(src.key % 10 AS INT), src.value US

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-10-29 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-547348708 Another issue: test query: ``` FROM (select 1 as key, 100 as value) src MAP src.*, src.key, CAST(src.key / 10 AS I

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-10-28 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-547250946 Follow up - I think It's even better to always use a manual aliasing function and not just for a subset of expressions: ``

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-10-28 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-547246714 Regarding the issue in https://github.com/apache/spark/pull/25028#issuecomment-547230458 Instead of ``` val nam

[GitHub] [spark] alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation.

2019-10-28 Thread GitBox
alfozan commented on issue #25028: [SPARK-28227][SQL] Support TRANSFORM with aggregation. URL: https://github.com/apache/spark/pull/25028#issuecomment-547230458 @AngersZh one small regression: test query: `MAP k / 10 USING 'cat' AS (one) from (select 10 as k); ` **Re