[GitHub] [spark] allisonwang-db commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

2020-10-26 Thread GitBox
allisonwang-db commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r512162304 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1242,6 +1242,13 @@ object SQLConf {

[GitHub] [spark] allisonwang-db commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

2020-10-26 Thread GitBox
allisonwang-db commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r512162304 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1242,6 +1242,13 @@ object SQLConf {

[GitHub] [spark] allisonwang-db commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

2020-10-26 Thread GitBox
allisonwang-db commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r512161304 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateSortsSuite.scala ## @@ -97,12 +97,34 @@ class

[GitHub] [spark] allisonwang-db commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

2020-10-22 Thread GitBox
allisonwang-db commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r509898482 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1052,11 +1052,11 @@ object

[GitHub] [spark] allisonwang-db commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

2020-10-21 Thread GitBox
allisonwang-db commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r509892889 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateSortsSuite.scala ## @@ -97,12 +97,27 @@ class