[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-15 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r898293801 ## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ## @@ -250,8 +251,18 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {

[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-14 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r897502115 ## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ## @@ -287,16 +298,37 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {

[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-14 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r897495588 ## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ## @@ -250,8 +251,18 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {

[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-14 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r897495588 ## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ## @@ -250,8 +251,18 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {

[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-13 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r896166516 ## sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala: ## @@ -681,4 +681,60 @@ class CatalogSuite extends SharedSparkSession with AnalysisTest w

[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-13 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r896163957 ## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ## @@ -287,16 +294,44 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {

[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-13 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r896161200 ## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ## @@ -250,8 +251,14 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {

[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-13 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r896156559 ## sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala: ## @@ -250,8 +251,14 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {

[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-10 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r894880544 ## sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala: ## @@ -681,4 +681,60 @@ class CatalogSuite extends SharedSparkSession with AnalysisTest w

[GitHub] [spark] amaliujia commented on a diff in pull request #36641: [SPARK-39263][SQL] Make GetTable, TableExists and DatabaseExists be compatible with 3 layer namespace

2022-06-10 Thread GitBox
amaliujia commented on code in PR #36641: URL: https://github.com/apache/spark/pull/36641#discussion_r894880106 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -966,7 +966,7 @@ class SessionCatalog( } def isGlobalTempViewD