[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018709403 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col

[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018685631 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col

[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018706220 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col

[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018704727 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col

[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018704727 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col

[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018704727 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col

[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018704727 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col

[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018686188 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col

[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018686188 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col

[GitHub] [spark] amaliujia commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

2022-11-09 Thread GitBox
amaliujia commented on code in PR #38586: URL: https://github.com/apache/spark/pull/38586#discussion_r1018685631 ## python/pyspark/sql/connect/column.py: ## @@ -30,8 +30,8 @@ def _bin_op( name: str, doc: str = "binary function", reverse: bool = False -) -> Callable[["Col