[GitHub] [spark] amaliujia commented on a diff in pull request #38621: [SPARK-41111][CONNECT][PYTHON] Implement `DataFrame.show`

2022-11-13 Thread GitBox
amaliujia commented on code in PR #38621: URL: https://github.com/apache/spark/pull/38621#discussion_r1021008154 ## python/pyspark/sql/tests/connect/test_connect_basic.py: ## @@ -217,6 +217,12 @@ def test_empty_dataset(self): def test_session(self): self.assertEqua

[GitHub] [spark] amaliujia commented on a diff in pull request #38621: [SPARK-41111][CONNECT][PYTHON] Implement `DataFrame.show`

2022-11-13 Thread GitBox
amaliujia commented on code in PR #38621: URL: https://github.com/apache/spark/pull/38621#discussion_r1021007865 ## python/pyspark/sql/tests/connect/test_connect_basic.py: ## @@ -217,6 +217,12 @@ def test_empty_dataset(self): def test_session(self): self.assertEqua

[GitHub] [spark] amaliujia commented on a diff in pull request #38621: [SPARK-41111][CONNECT][PYTHON] Implement `DataFrame.show`

2022-11-11 Thread GitBox
amaliujia commented on code in PR #38621: URL: https://github.com/apache/spark/pull/38621#discussion_r1020483723 ## connector/connect/src/main/protobuf/spark/connect/relations.proto: ## @@ -253,6 +254,23 @@ message Repartition { bool shuffle = 3; } +// Compose the string r

[GitHub] [spark] amaliujia commented on a diff in pull request #38621: [SPARK-41111][CONNECT][PYTHON] Implement `DataFrame.show`

2022-11-11 Thread GitBox
amaliujia commented on code in PR #38621: URL: https://github.com/apache/spark/pull/38621#discussion_r1020488570 ## python/pyspark/sql/tests/connect/test_connect_basic.py: ## @@ -217,6 +217,12 @@ def test_empty_dataset(self): def test_session(self): self.assertEqua

[GitHub] [spark] amaliujia commented on a diff in pull request #38621: [SPARK-41111][CONNECT][PYTHON] Implement `DataFrame.show`

2022-11-11 Thread GitBox
amaliujia commented on code in PR #38621: URL: https://github.com/apache/spark/pull/38621#discussion_r1020488570 ## python/pyspark/sql/tests/connect/test_connect_basic.py: ## @@ -217,6 +217,12 @@ def test_empty_dataset(self): def test_session(self): self.assertEqua

[GitHub] [spark] amaliujia commented on a diff in pull request #38621: [SPARK-41111][CONNECT][PYTHON] Implement `DataFrame.show`

2022-11-11 Thread GitBox
amaliujia commented on code in PR #38621: URL: https://github.com/apache/spark/pull/38621#discussion_r1020484857 ## connector/connect/src/main/protobuf/spark/connect/relations.proto: ## @@ -253,6 +254,23 @@ message Repartition { bool shuffle = 3; } +// Compose the string r

[GitHub] [spark] amaliujia commented on a diff in pull request #38621: [SPARK-41111][CONNECT][PYTHON] Implement `DataFrame.show`

2022-11-11 Thread GitBox
amaliujia commented on code in PR #38621: URL: https://github.com/apache/spark/pull/38621#discussion_r1020483723 ## connector/connect/src/main/protobuf/spark/connect/relations.proto: ## @@ -253,6 +254,23 @@ message Repartition { bool shuffle = 3; } +// Compose the string r