[GitHub] [spark] amaliujia commented on a diff in pull request #38631: [SPARK-40809] [CONNECT] [FOLLOW] Support `alias()` in Python client

2022-11-11 Thread GitBox
amaliujia commented on code in PR #38631: URL: https://github.com/apache/spark/pull/38631#discussion_r1020563219 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -334,7 +334,11 @@ class SparkConnectPlanner(session: SparkSe

[GitHub] [spark] amaliujia commented on a diff in pull request #38631: [SPARK-40809] [CONNECT] [FOLLOW] Support `alias()` in Python client

2022-11-11 Thread GitBox
amaliujia commented on code in PR #38631: URL: https://github.com/apache/spark/pull/38631#discussion_r1020563219 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -334,7 +334,11 @@ class SparkConnectPlanner(session: SparkSe

[GitHub] [spark] amaliujia commented on a diff in pull request #38631: [SPARK-40809] [CONNECT] [FOLLOW] Support `alias()` in Python client

2022-11-11 Thread GitBox
amaliujia commented on code in PR #38631: URL: https://github.com/apache/spark/pull/38631#discussion_r1020561328 ## python/pyspark/sql/connect/column.py: ## @@ -82,6 +82,74 @@ def to_plan(self, session: "RemoteSparkSession") -> "proto.Expression": def __str__(self) -> str:

[GitHub] [spark] amaliujia commented on a diff in pull request #38631: [SPARK-40809] [CONNECT] [FOLLOW] Support `alias()` in Python client

2022-11-11 Thread GitBox
amaliujia commented on code in PR #38631: URL: https://github.com/apache/spark/pull/38631#discussion_r1020561852 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -334,7 +334,11 @@ class SparkConnectPlanner(session: SparkSe