[GitHub] [spark] amaliujia commented on a diff in pull request #38653: [SPARK-41128][CONNECT][PYTHON] Implement `DataFrame.fillna ` and `DataFrame.na.fill `

2022-11-14 Thread GitBox
amaliujia commented on code in PR #38653: URL: https://github.com/apache/spark/pull/38653#discussion_r1022273256 ## python/pyspark/sql/tests/connect/test_connect_plan_only.py: ## @@ -70,6 +70,37 @@ def test_filter(self): self.assertEqual(plan.root.filter.condition.unres

[GitHub] [spark] amaliujia commented on a diff in pull request #38653: [SPARK-41128][CONNECT][PYTHON] Implement `DataFrame.fillna ` and `DataFrame.na.fill `

2022-11-14 Thread GitBox
amaliujia commented on code in PR #38653: URL: https://github.com/apache/spark/pull/38653#discussion_r1022273256 ## python/pyspark/sql/tests/connect/test_connect_plan_only.py: ## @@ -70,6 +70,37 @@ def test_filter(self): self.assertEqual(plan.root.filter.condition.unres

[GitHub] [spark] amaliujia commented on a diff in pull request #38653: [SPARK-41128][CONNECT][PYTHON] Implement `DataFrame.fillna ` and `DataFrame.na.fill `

2022-11-14 Thread GitBox
amaliujia commented on code in PR #38653: URL: https://github.com/apache/spark/pull/38653#discussion_r1022249117 ## connector/connect/src/main/protobuf/spark/connect/relations.proto: ## @@ -316,6 +319,36 @@ message StatCrosstab { string col2 = 3; } +// Replaces null values