[GitHub] [spark] amaliujia commented on pull request #38609: [SPARK-40593][BUILD][CONNECT] Make user can build and test `connect` module by specifying the user-defined `protoc` and `protoc-gen-grpc-ja

amaliujia commented on PR #38609: URL: https://github.com/apache/spark/pull/38609#issuecomment-1318054981 Checking with @grundprinzip to see if there are more comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [spark] amaliujia commented on pull request #38609: [SPARK-40593][BUILD][CONNECT] Make user can build and test `connect` module by specifying the user-defined `protoc` and `protoc-gen-grpc-ja

amaliujia commented on PR #38609: URL: https://github.com/apache/spark/pull/38609#issuecomment-1314615345 LGTM assuming this is tested manually (seems to be hard have a UT) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [spark] amaliujia commented on pull request #38609: [SPARK-40593][BUILD][CONNECT] Make user can build and test `connect` module by specifying the user-defined `protoc` and `protoc-gen-grpc-ja

amaliujia commented on PR #38609: URL: https://github.com/apache/spark/pull/38609#issuecomment-1314293906 Looks easy to follow! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen