anishshri-db commented on code in PR #35484:
URL: https://github.com/apache/spark/pull/35484#discussion_r890722033
##########
connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/consumer/KafkaDataConsumer.scala:
##########
@@ -298,9 +296,10 @@ private[kafka010] class KafkaDataConsumer(
s"requested $offset")
// The following loop is basically for `failOnDataLoss = false`. When
`failOnDataLoss` is
- // `false`, first, we will try to fetch the record at `offset`. If no such
record exists, then
- // we will move to the next available offset within `[offset,
untilOffset)` and retry.
- // If `failOnDataLoss` is `true`, the loop body will be executed only once.
+ // `false`, we will try to fetch the record at `offset`, if the record
does not exist, we will
+ // try to fetch next available record within [offset, untilOffset).
+ // If `failOnDataLoss` is `true`, the loop body will be executed only
once, either return the
+ // record at `offset` or throw an exception when the record does not exist
Review Comment:
Nit: Period at the end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
