[GitHub] [spark] attilapiros commented on a diff in pull request #39728: [SPARK-42173][CORE] RpcAddress equality can fail

2023-01-25 Thread via GitHub
attilapiros commented on code in PR #39728: URL: https://github.com/apache/spark/pull/39728#discussion_r1087515031 ## core/src/main/scala/org/apache/spark/util/Utils.scala: ## @@ -1118,7 +1118,7 @@ private[spark] object Utils extends Logging { // This means some invalid add

[GitHub] [spark] attilapiros commented on a diff in pull request #39728: [SPARK-42173][CORE] RpcAddress equality can fail

2023-01-25 Thread via GitHub
attilapiros commented on code in PR #39728: URL: https://github.com/apache/spark/pull/39728#discussion_r1087250704 ## core/src/main/scala/org/apache/spark/util/Utils.scala: ## @@ -1118,7 +1118,7 @@ private[spark] object Utils extends Logging { // This means some invalid add

[GitHub] [spark] attilapiros commented on a diff in pull request #39728: [SPARK-42173][CORE] RpcAddress equality can fail

2023-01-25 Thread via GitHub
attilapiros commented on code in PR #39728: URL: https://github.com/apache/spark/pull/39728#discussion_r1087190921 ## core/src/main/scala/org/apache/spark/util/Utils.scala: ## @@ -1109,6 +1109,24 @@ private[spark] object Utils extends Logging { } } + /** + * Normali