[GitHub] [spark] attilapiros commented on pull request #33936: [SPARK-36693][REPL] Implement spark-shell idle timeouts

2021-12-15 Thread GitBox
attilapiros commented on pull request #33936: URL: https://github.com/apache/spark/pull/33936#issuecomment-994875652 Thanks @gyogal working on this! Now I have closed this and when we have a good solution we can open a new PR for this. -- This is an automated message from the Apache Git

[GitHub] [spark] attilapiros commented on pull request #33936: [SPARK-36693][REPL] Implement spark-shell idle timeouts

2021-10-01 Thread GitBox
attilapiros commented on pull request #33936: URL: https://github.com/apache/spark/pull/33936#issuecomment-932415908 I was testing this PR and there is problem. When the shell is just started and no expressions are evaluated but only empty lines are entered the inactivity timer are not sto

[GitHub] [spark] attilapiros commented on pull request #33936: [SPARK-36693][REPL] Implement spark-shell idle timeouts

2021-09-08 Thread GitBox
attilapiros commented on pull request #33936: URL: https://github.com/apache/spark/pull/33936#issuecomment-915178351 > I'm afraid this might kill the shell if a command is running for a long time? it triggers on commands. @srowen I do not think as before the command is starte

[GitHub] [spark] attilapiros commented on pull request #33936: [SPARK-36693][REPL] Implement spark-shell idle timeouts

2021-09-08 Thread GitBox
attilapiros commented on pull request #33936: URL: https://github.com/apache/spark/pull/33936#issuecomment-915098452 cc @srowen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [spark] attilapiros commented on pull request #33936: [SPARK-36693][REPL] Implement spark-shell idle timeouts

2021-09-08 Thread GitBox
attilapiros commented on pull request #33936: URL: https://github.com/apache/spark/pull/33936#issuecomment-915059558 As I see this is your first PR for Apache Spark welcome here and thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [spark] attilapiros commented on pull request #33936: [SPARK-36693][REPL] Implement spark-shell idle timeouts

2021-09-08 Thread GitBox
attilapiros commented on pull request #33936: URL: https://github.com/apache/spark/pull/33936#issuecomment-915047136 Apache Spark leverages the resources of GitHub Actions in your forked repository to test your PR. Please enable it, see also https://github.com/apache/spark/pull/33936/check

[GitHub] [spark] attilapiros commented on pull request #33936: [SPARK-36693][REPL] Implement spark-shell idle timeouts

2021-09-08 Thread GitBox
attilapiros commented on pull request #33936: URL: https://github.com/apache/spark/pull/33936#issuecomment-915040138 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme