[GitHub] [spark] bart-samwel commented on pull request #29181: [SPARK-32383][SQL] Preserve hash join (BHJ and SHJ) stream side ordering

2020-07-23 Thread GitBox
bart-samwel commented on pull request #29181: URL: https://github.com/apache/spark/pull/29181#issuecomment-663059685 > @bart-samwel - just to bring us in the same page. > > Current spark scala/java implementation for hash join (broadcast hash join and shuffled hash join) has followin

[GitHub] [spark] bart-samwel commented on pull request #29181: [SPARK-32383][SQL] Preserve hash join (BHJ and SHJ) stream side ordering

2020-07-22 Thread GitBox
bart-samwel commented on pull request #29181: URL: https://github.com/apache/spark/pull/29181#issuecomment-662483694 Can you double check that the ordering is correct if there are NULLs involved, or outer join conditions? The tricky cases I see: - RIGHT / FULL SHJ. If the streaming /