[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r571520105 ## File path: sql/core/src/test/resources/sql-tests/results/show-tables.sql.out ## @@ -61,7 +61,7 @@ struct<> -- !query SHOW TABLES -- !query schema

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r571519294 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -342,18 +342,32 @@ class

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r571519198 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r570791022 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r570791022 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r570815288 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala ## @@ -119,6 +102,34 @@ trait ShowTablesSuiteBase

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r568478901 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala ## @@ -37,13 +36,14 @@ trait ShowTablesSuiteBase

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r568478901 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala ## @@ -37,13 +36,14 @@ trait ShowTablesSuiteBase

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r566539660 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala ## @@ -138,4 +121,21 @@ class ShowTablesSuite

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r566539660 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala ## @@ -138,4 +121,21 @@ class ShowTablesSuite

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r566539660 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala ## @@ -138,4 +121,21 @@ class ShowTablesSuite

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r566536364 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala ## @@ -37,13 +36,14 @@ trait ShowTablesSuiteBase

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r566536364 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala ## @@ -37,13 +36,14 @@ trait ShowTablesSuiteBase

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565963610 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/ShowTablesSuite.scala ## @@ -19,21 +19,15 @@ package

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565842071 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala ## @@ -34,7 +35,7 @@ trait ShowTablesSuiteBase

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565841306 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565841011 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565787279 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565783250 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ## @@ -668,7 +675,7 @@ class SQLContext private[sql](val sparkSession:

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r564987128 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -835,21 +835,11 @@ case class DescribeColumnCommand(

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r564225042 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -835,22 +835,23 @@ case class DescribeColumnCommand(

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r564210978 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala ## @@ -40,7 +40,7 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r562391414 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala ## @@ -40,7 +40,7 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r562391414 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala ## @@ -40,7 +40,7 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r560924934 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ## @@ -2013,6 +2014,21 @@ abstract class DDLSuite extends

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r560684517 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ## @@ -2013,6 +2014,19 @@ abstract class DDLSuite extends

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r560683783 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ## @@ -33,6 +33,7 @@ import

[GitHub] [spark] beliefer commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

beliefer commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r560682574 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -835,21 +835,11 @@ case class DescribeColumnCommand(