[GitHub] [spark] beliefer commented on a change in pull request #32442: [SPARK-35283][SQL] Support query some DDL with CTES

2021-05-10 Thread GitBox
beliefer commented on a change in pull request #32442: URL: https://github.com/apache/spark/pull/32442#discussion_r629173670 ## File path: sql/core/src/test/resources/sql-tests/results/cte-ddl.sql.out ## @@ -0,0 +1,1152 @@ +-- Automatically generated by SQLQueryTestSuite +-- Nu

[GitHub] [spark] beliefer commented on a change in pull request #32442: [SPARK-35283][SQL] Support query some DDL with CTES

2021-05-10 Thread GitBox
beliefer commented on a change in pull request #32442: URL: https://github.com/apache/spark/pull/32442#discussion_r629170207 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -375,8 +363,18 @@ ctes : WITH namedQuery (',' name

[GitHub] [spark] beliefer commented on a change in pull request #32442: [SPARK-35283][SQL] Support query some DDL with CTES

2021-05-09 Thread GitBox
beliefer commented on a change in pull request #32442: URL: https://github.com/apache/spark/pull/32442#discussion_r629016341 ## File path: sql/core/src/test/resources/sql-tests/inputs/cte-ddl.sql ## @@ -0,0 +1,65 @@ +-- Test data. +CREATE NAMESPACE IF NOT EXISTS query_ddl_names

[GitHub] [spark] beliefer commented on a change in pull request #32442: [SPARK-35283][SQL] Support query some DDL with CTES

2021-05-07 Thread GitBox
beliefer commented on a change in pull request #32442: URL: https://github.com/apache/spark/pull/32442#discussion_r628676333 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala ## @@ -84,6 +84,8 @@ class Th

[GitHub] [spark] beliefer commented on a change in pull request #32442: [SPARK-35283][SQL] Support query some DDL with CTES

2021-05-07 Thread GitBox
beliefer commented on a change in pull request #32442: URL: https://github.com/apache/spark/pull/32442#discussion_r628676333 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala ## @@ -84,6 +84,8 @@ class Th

[GitHub] [spark] beliefer commented on a change in pull request #32442: [SPARK-35283][SQL] Support query some DDL with CTES

2021-05-07 Thread GitBox
beliefer commented on a change in pull request #32442: URL: https://github.com/apache/spark/pull/32442#discussion_r628676259 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala ## @@ -84,6 +84,8 @@ class Th

[GitHub] [spark] beliefer commented on a change in pull request #32442: [SPARK-35283][SQL] Support query some DDL with CTES

2021-05-07 Thread GitBox
beliefer commented on a change in pull request #32442: URL: https://github.com/apache/spark/pull/32442#discussion_r628102379 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -193,13 +193,32 @@ class AstBuilder extends SqlBas

[GitHub] [spark] beliefer commented on a change in pull request #32442: [SPARK-35283][SQL] Support query some DDL with CTES

2021-05-07 Thread GitBox
beliefer commented on a change in pull request #32442: URL: https://github.com/apache/spark/pull/32442#discussion_r628040787 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala ## @@ -84,6 +84,8 @@ class Th