beliefer commented on code in PR #34474:
URL: https://github.com/apache/spark/pull/34474#discussion_r978252209
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/AggregatingAccumulator.scala:
##########
@@ -188,6 +197,17 @@ class AggregatingAccumulator private(
resultProjection(input)
}
+ override def withBufferSerialized(): AggregatingAccumulator = {
+ assert(!isAtDriverSide)
+ var i = 0
+ // AggregatingAccumulator runs on executor, we should serialize all
TypedImperativeAggregate.
+ while (i < typedImperatives.length) {
+ typedImperatives(i).serializeAggregateBufferInPlace(buffer)
Review Comment:
I will investigate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
