beliefer commented on code in PR #36043:
URL: https://github.com/apache/spark/pull/36043#discussion_r843371002
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala:
##########
@@ -380,27 +380,32 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper wit
sHolder.pushedLimit = Some(limit)
sHolder.sortOrders = orders
if (isPartiallyPushed) {
- s
+ (s, isPartiallyPushed)
} else {
- operation
+ (operation, isPartiallyPushed)
}
} else {
- s
+ (s, true)
}
} else {
- s
+ (s, true)
}
case p: Project =>
- val newChild = pushDownLimit(p.child, limit)
- p.withNewChildren(Seq(newChild))
- case other => other
+ val (newChild, isPartiallyPushed) = pushDownLimit(p.child, limit)
+ (p.withNewChildren(Seq(newChild)), isPartiallyPushed)
+ case other => (other, true)
}
def pushDownLimits(plan: LogicalPlan): LogicalPlan = plan.transform {
case globalLimit @ Limit(IntegerLiteral(limitValue), child) =>
- val newChild = pushDownLimit(child, limitValue)
- val newLocalLimit =
globalLimit.child.asInstanceOf[LocalLimit].withNewChildren(Seq(newChild))
- globalLimit.withNewChildren(Seq(newLocalLimit))
+ val (newChild, isPartiallyPushed) = pushDownLimit(child, limitValue)
+ if (isPartiallyPushed) {
+ val newLocalLimit =
+
globalLimit.child.asInstanceOf[LocalLimit].withNewChildren(Seq(newChild))
+ globalLimit.withNewChildren(Seq(newLocalLimit))
+ } else {
+ newChild
Review Comment:
Thank you for the reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
