[GitHub] [spark] beliefer commented on a diff in pull request #36405: [SPARK-39065][SQL] DS V2 Limit push-down should avoid out of memory

2022-05-02 Thread GitBox
beliefer commented on code in PR #36405: URL: https://github.com/apache/spark/pull/36405#discussion_r863326711 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCScanBuilder.scala: ## @@ -131,7 +131,8 @@ case class JDBCScanBuilder( } overri

[GitHub] [spark] beliefer commented on a diff in pull request #36405: [SPARK-39065][SQL] DS V2 Limit push-down should avoid out of memory

2022-05-09 Thread GitBox
beliefer commented on code in PR #36405: URL: https://github.com/apache/spark/pull/36405#discussion_r867816015 ## docs/sql-data-sources-jdbc.md: ## @@ -286,6 +286,15 @@ logging into the data sources. read + +maxPushDownLimit Review Comment: OK -- This is