[GitHub] [spark] beliefer commented on a diff in pull request #36773: [SPARK-39385][SQL] Translate linear regression aggregate functions for pushdown

2022-07-05 Thread GitBox
beliefer commented on code in PR #36773: URL: https://github.com/apache/spark/pull/36773#discussion_r913565329 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -62,18 +62,27 @@ private[sql] object H2Dialect extends JdbcDialect {

[GitHub] [spark] beliefer commented on a diff in pull request #36773: [SPARK-39385][SQL] Translate linear regression aggregate functions for pushdown

2022-07-05 Thread GitBox
beliefer commented on code in PR #36773: URL: https://github.com/apache/spark/pull/36773#discussion_r913493163 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -62,18 +62,27 @@ private[sql] object H2Dialect extends JdbcDialect {

[GitHub] [spark] beliefer commented on a diff in pull request #36773: [SPARK-39385][SQL] Translate linear regression aggregate functions for pushdown

2022-07-05 Thread GitBox
beliefer commented on code in PR #36773: URL: https://github.com/apache/spark/pull/36773#discussion_r913478436 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -62,18 +62,27 @@ private[sql] object H2Dialect extends JdbcDialect {

[GitHub] [spark] beliefer commented on a diff in pull request #36773: [SPARK-39385][SQL] Translate linear regression aggregate functions for pushdown

2022-07-05 Thread GitBox
beliefer commented on code in PR #36773: URL: https://github.com/apache/spark/pull/36773#discussion_r913478436 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -62,18 +62,27 @@ private[sql] object H2Dialect extends JdbcDialect {

[GitHub] [spark] beliefer commented on a diff in pull request #36773: [SPARK-39385][SQL] Translate linear regression aggregate functions for pushdown

2022-06-06 Thread GitBox
beliefer commented on code in PR #36773: URL: https://github.com/apache/spark/pull/36773#discussion_r890715857 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala: ## @@ -750,6 +750,22 @@ object DataSourceStrategy

[GitHub] [spark] beliefer commented on a diff in pull request #36773: [SPARK-39385][SQL] Translate linear regression aggregate functions for pushdown

2022-06-06 Thread GitBox
beliefer commented on code in PR #36773: URL: https://github.com/apache/spark/pull/36773#discussion_r890714758 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -72,6 +72,26 @@ private[sql] object H2Dialect extends JdbcDialect {

[GitHub] [spark] beliefer commented on a diff in pull request #36773: [SPARK-39385][SQL] Translate linear regression aggregate functions for pushdown

2022-06-06 Thread GitBox
beliefer commented on code in PR #36773: URL: https://github.com/apache/spark/pull/36773#discussion_r890696454 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -,6 +,28 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with

[GitHub] [spark] beliefer commented on a diff in pull request #36773: [SPARK-39385][SQL] Translate linear regression aggregate functions for pushdown

2022-06-06 Thread GitBox
beliefer commented on code in PR #36773: URL: https://github.com/apache/spark/pull/36773#discussion_r890694554 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -72,6 +72,26 @@ private[sql] object H2Dialect extends JdbcDialect {