subject:"\[GitHub\] \[spark\] beliefer commented on a diff in pull request #36830\: \[SPARK\-38761\]\[SQL\]\[FOLLOWUP\] DS V2 supports push down misc non\-aggregate functions"

[GitHub] [spark] beliefer commented on a diff in pull request #36830: [SPARK-38761][SQL][FOLLOWUP] DS V2 supports push down misc non-aggregate functions

2022-06-12 Thread GitBox

beliefer commented on code in PR #36830: URL: https://github.com/apache/spark/pull/36830#discussion_r895270044 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -97,6 +97,10 @@ public String build(Expression expr) { r

[GitHub] [spark] beliefer commented on a diff in pull request #36830: [SPARK-38761][SQL][FOLLOWUP] DS V2 supports push down misc non-aggregate functions

2022-06-12 Thread GitBox

beliefer commented on code in PR #36830: URL: https://github.com/apache/spark/pull/36830#discussion_r895270044 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -97,6 +97,10 @@ public String build(Expression expr) { r