[GitHub] [spark] beliefer commented on a diff in pull request #40275: [SPARK-42557][CONNECT] Add Broadcast to functions

2023-03-05 Thread via GitHub
beliefer commented on code in PR #40275: URL: https://github.com/apache/spark/pull/40275#discussion_r1125652836 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala: ## @@ -1228,6 +1228,22 @@ object functions { def map_from_arrays(keys: Column,

[GitHub] [spark] beliefer commented on a diff in pull request #40275: [SPARK-42557][CONNECT] Add Broadcast to functions

2023-03-05 Thread via GitHub
beliefer commented on code in PR #40275: URL: https://github.com/apache/spark/pull/40275#discussion_r1125652564 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala: ## @@ -489,17 +489,31 @@ class ClientE2ETestSuite extends RemoteSparkSess

[GitHub] [spark] beliefer commented on a diff in pull request #40275: [SPARK-42557][CONNECT] Add Broadcast to functions

2023-03-05 Thread via GitHub
beliefer commented on code in PR #40275: URL: https://github.com/apache/spark/pull/40275#discussion_r1125651656 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala: ## @@ -489,17 +489,31 @@ class ClientE2ETestSuite extends RemoteSparkSess