[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1284966377 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateJoinByCombineAggregate.scala: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softw

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1284414503 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1284113208 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1283905000 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1283903546 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1283895467 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateJoinByCombineAggregate.scala: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softw

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1283057743 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1283026154 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1283024534 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281825698 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281825698 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281561980 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281560378 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281460766 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281537652 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateJoinByCombineAggregate.scala: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softw

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281532731 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateJoinByCombineAggregate.scala: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softw

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281475085 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281465743 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueriesHelper.scala: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software F

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281461848 ## sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CombineJoinedAggregatesBenchmark.scala: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281460766 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281430619 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1281430619 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CombineJoinedAggregates.scala: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1280319320 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueriesHelper.scala: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software F

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1279162753 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateJoinByCombineAggregate.scala: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softw

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1279058393 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateJoinByCombineAggregate.scala: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softw

[GitHub] [spark] beliefer commented on a diff in pull request #42223: [SPARK-44571][SQL] Eliminate the Join by combine multiple Aggregates

beliefer commented on code in PR #42223: URL: https://github.com/apache/spark/pull/42223#discussion_r1278949683 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateJoinByCombineAggregate.scala: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softw