[GitHub] [spark] beliefer commented on pull request #35041: [SPARK-37691][SQL] Support ANSI Aggregation Function: `percentile_disc`

2022-04-19 Thread GitBox
beliefer commented on PR #35041: URL: https://github.com/apache/spark/pull/35041#issuecomment-1103345609 @cloud-fan Thank you very much! @MaxGekk @jiangxb1987 Thank you too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] beliefer commented on pull request #35041: [SPARK-37691][SQL] Support ANSI Aggregation Function: `percentile_disc`

2022-04-19 Thread GitBox
beliefer commented on PR #35041: URL: https://github.com/apache/spark/pull/35041#issuecomment-1102496054 ping @cloud-fan The test build: https://github.com/beliefer/spark/actions/runs/2188382024 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] beliefer commented on pull request #35041: [SPARK-37691][SQL] Support ANSI Aggregation Function: `percentile_disc`

2022-03-28 Thread GitBox
beliefer commented on pull request #35041: URL: https://github.com/apache/spark/pull/35041#issuecomment-1081308706 ping @MaxGekk again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [spark] beliefer commented on pull request #35041: [SPARK-37691][SQL] Support ANSI Aggregation Function: `percentile_disc`

2022-03-25 Thread GitBox
beliefer commented on pull request #35041: URL: https://github.com/apache/spark/pull/35041#issuecomment-1079548540 > @beliefer Could you resolve conflicts, please. OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] beliefer commented on pull request #35041: [SPARK-37691][SQL] Support ANSI Aggregation Function: `percentile_disc`

2022-03-05 Thread GitBox
beliefer commented on pull request #35041: URL: https://github.com/apache/spark/pull/35041#issuecomment-1059718815 > The changes looks good, need extra time to review the `getPercentile` function. > > Can you please improvement the test coverage by refactoring the test suite `Percen

[GitHub] [spark] beliefer commented on pull request #35041: [SPARK-37691][SQL] Support ANSI Aggregation Function: `percentile_disc`

2022-01-26 Thread GitBox
beliefer commented on pull request #35041: URL: https://github.com/apache/spark/pull/35041#issuecomment-1022751663 ping @MaxGekk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [spark] beliefer commented on pull request #35041: [SPARK-37691][SQL] Support ANSI Aggregation Function: `percentile_disc`

2022-01-05 Thread GitBox
beliefer commented on pull request #35041: URL: https://github.com/apache/spark/pull/35041#issuecomment-1005619977 @MaxGekk Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] beliefer commented on pull request #35041: [SPARK-37691][SQL] Support ANSI Aggregation Function: percentile_disc

2021-12-29 Thread GitBox
beliefer commented on pull request #35041: URL: https://github.com/apache/spark/pull/35041#issuecomment-1002456224 ping @MaxGekk @gengliangwang cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab