brkyvz commented on a change in pull request #27650: [SPARK-30902][SQL] Default
table provider should be decided by catalog implementations
URL: https://github.com/apache/spark/pull/27650#discussion_r385542474
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -174,7 +174,7 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
c.tableSchema,
// convert the bucket spec and add it as a transform
c.partitioning ++ c.bucketSpec.map(_.asTransform),
- convertTableProperties(c.properties, c.options, c.location, c.comment,
c.provider),
+ convertTableProperties(c.properties, c.options, c.location, c.comment,
Some(c.provider)),
Review comment:
Can the parser return this as `null`? If so, shouldn't these be
`Option(c.provider)` so that they don't return null providers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
