[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-16 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r471143081 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-15 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r471022667 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,68 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470908654 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +85,215 @@ case class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470884973 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470884722 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +85,215 @@ case class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470883805 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +85,215 @@ case class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470855625 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -66,6 +66,30 @@ private[execution] sealed trait

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470854938 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,68 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470753712 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +85,215 @@ case class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470271904 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -314,7 +338,9 @@ private[joins] object

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470251281 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470240912 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470240912 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470237884 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,64 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470236922 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470224648 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470169165 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470214602 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +85,210 @@ case class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470201781 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-12 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r469569295 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,42 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-09 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r467674611 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,42 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-09 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r467653620 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +88,122 @@ case class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-09 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r467652923 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +88,122 @@ case class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-08 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r467505445 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +88,122 @@ case class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-08 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r467502239 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -58,8 +65,19 @@ case class ShuffledHashJoinExec(

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-07 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r467157300 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -97,7 +102,9 @@ private[execution] object

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-04 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r465330581 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +89,137 @@ case class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-04 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r465330063 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -305,6 +315,27 @@ private[joins] class

[GitHub] [spark] c21 commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-04 Thread GitBox
c21 commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r465329042 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -128,15 +135,18 @@ private[execution] object