[GitHub] [spark] c21 commented on a change in pull request #29455: [SPARK-32644][SQL] NAAJ support for ShuffleHashJoin when AQE is on

2020-08-19 Thread GitBox
c21 commented on a change in pull request #29455: URL: https://github.com/apache/spark/pull/29455#discussion_r47338 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -317,4 +318,41 @@ case class ShuffledHashJoinExec

[GitHub] [spark] c21 commented on a change in pull request #29455: [SPARK-32644][SQL] NAAJ support for ShuffleHashJoin when AQE is on

2020-08-18 Thread GitBox
c21 commented on a change in pull request #29455: URL: https://github.com/apache/spark/pull/29455#discussion_r472706333 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateNullAwareAntiJoin.scala ## @@ -20,22 +20,50 @@ package org.apache.spar

[GitHub] [spark] c21 commented on a change in pull request #29455: [SPARK-32644][SQL] NAAJ support for ShuffleHashJoin when AQE is on

2020-08-18 Thread GitBox
c21 commented on a change in pull request #29455: URL: https://github.com/apache/spark/pull/29455#discussion_r472680557 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala ## @@ -83,15 +83,18 @@ trait ShuffleExchangeLike exte

[GitHub] [spark] c21 commented on a change in pull request #29455: [SPARK-32644][SQL] NAAJ support for ShuffleHashJoin when AQE is on

2020-08-18 Thread GitBox
c21 commented on a change in pull request #29455: URL: https://github.com/apache/spark/pull/29455#discussion_r472583133 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ## @@ -235,8 +235,13 @@ abstract class SparkStrategies extends Qu

[GitHub] [spark] c21 commented on a change in pull request #29455: [SPARK-32644][SQL] NAAJ support for ShuffleHashJoin when AQE is on

2020-08-18 Thread GitBox
c21 commented on a change in pull request #29455: URL: https://github.com/apache/spark/pull/29455#discussion_r472574563 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala ## @@ -83,15 +83,18 @@ trait ShuffleExchangeLike exte

[GitHub] [spark] c21 commented on a change in pull request #29455: [SPARK-32644][SQL] NAAJ support for ShuffleHashJoin when AQE is on

2020-08-18 Thread GitBox
c21 commented on a change in pull request #29455: URL: https://github.com/apache/spark/pull/29455#discussion_r472503907 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala ## @@ -83,15 +83,18 @@ trait ShuffleExchangeLike exte