[GitHub] [spark] c21 commented on pull request #29181: [SPARK-32383][SQL] Preserve hash join (BHJ and SHJ) stream side ordering

2020-07-26 Thread GitBox
c21 commented on pull request #29181: URL: https://github.com/apache/spark/pull/29181#issuecomment-664121981 Thanks @cloud-fan and @bart-samwel for review and discussion! This is an automated message from the Apache Git Servi

[GitHub] [spark] c21 commented on pull request #29181: [SPARK-32383][SQL] Preserve hash join (BHJ and SHJ) stream side ordering

2020-07-25 Thread GitBox
c21 commented on pull request #29181: URL: https://github.com/apache/spark/pull/29181#issuecomment-663867974 @cloud-fan gentle ping, could you help take another look? Thanks. This is an automated message from the Apache Git S

[GitHub] [spark] c21 commented on pull request #29181: [SPARK-32383][SQL] Preserve hash join (BHJ and SHJ) stream side ordering

2020-07-23 Thread GitBox
c21 commented on pull request #29181: URL: https://github.com/apache/spark/pull/29181#issuecomment-663129725 > Delta engine will indeed support full outer join in SHJ. @bart-samwel - sounds good. I will work on to support full outer join in SHJ at its current java stack then in http

[GitHub] [spark] c21 commented on pull request #29181: [SPARK-32383][SQL] Preserve hash join (BHJ and SHJ) stream side ordering

2020-07-22 Thread GitBox
c21 commented on pull request #29181: URL: https://github.com/apache/spark/pull/29181#issuecomment-662704525 @bart-samwel - just to bring us in the same page. Current spark scala/java implementation for hash join (broadcast hash join and shuffled hash join) has following restriction:

[GitHub] [spark] c21 commented on pull request #29181: [SPARK-32383][SQL] Preserve hash join (BHJ and SHJ) stream side ordering

2020-07-21 Thread GitBox
c21 commented on pull request #29181: URL: https://github.com/apache/spark/pull/29181#issuecomment-662177572 cc @cloud-fan and @sameeragarwal if you guys can help take a look. Thanks! This is an automated message from the Apa