[GitHub] [spark] c21 commented on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-14 Thread GitBox
c21 commented on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-859364748 cc @cloud-fan could you help take a look when you have time? Will craft more unit tests if we have consensus on overall design, thanks. -- This is an automated message from the

[GitHub] [spark] c21 commented on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-18 Thread GitBox
c21 commented on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-863916699 @cloud-fan - thank you for offline discussion and update the PR to use the discussed approach. Thanks. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [spark] c21 commented on pull request #32881: [SPARK-33298][CORE] Decouple file naming from FileCommitProtocol

2021-06-26 Thread GitBox
c21 commented on pull request #32881: URL: https://github.com/apache/spark/pull/32881#issuecomment-869078476 Update: we decided to go with https://github.com/apache/spark/pull/33012 instead of this PR, as we know [some other projects](https://github.com/delta-io/delta/blob/master/core/src/