[GitHub] [spark] chitralverma commented on issue #25122: [SPARK-28286][SQL][PYTHON][TESTS][WIP] Convert and port 'pivot.sql' into UDF test base

2019-07-11 Thread GitBox
chitralverma commented on issue #25122: [SPARK-28286][SQL][PYTHON][TESTS][WIP] Convert and port 'pivot.sql' into UDF test base URL: https://github.com/apache/spark/pull/25122#issuecomment-510682452 @HyukjinKwon I've raised this PR as a WIP till I incorporate your comments. I had some doubt

[GitHub] [spark] chitralverma commented on issue #25122: [SPARK-28286][SQL][PYTHON][TESTS][WIP] Convert and port 'pivot.sql' into UDF test base

2019-07-11 Thread GitBox
chitralverma commented on issue #25122: [SPARK-28286][SQL][PYTHON][TESTS][WIP] Convert and port 'pivot.sql' into UDF test base URL: https://github.com/apache/spark/pull/25122#issuecomment-510751215 @HyukjinKwon Thanks for your review comments, I've replied to them. I feel the sugges

[GitHub] [spark] chitralverma commented on issue #25122: [SPARK-28286][SQL][PYTHON][TESTS][WIP] Convert and port 'pivot.sql' into UDF test base

2019-07-18 Thread GitBox
chitralverma commented on issue #25122: [SPARK-28286][SQL][PYTHON][TESTS][WIP] Convert and port 'pivot.sql' into UDF test base URL: https://github.com/apache/spark/pull/25122#issuecomment-512695277 @HyukjinKwon I'm merging the changes and testing. will ping you once its done. thanks -

[GitHub] [spark] chitralverma commented on issue #25122: [SPARK-28286][SQL][PYTHON][TESTS][WIP] Convert and port 'pivot.sql' into UDF test base

2019-07-18 Thread GitBox
chitralverma commented on issue #25122: [SPARK-28286][SQL][PYTHON][TESTS][WIP] Convert and port 'pivot.sql' into UDF test base URL: https://github.com/apache/spark/pull/25122#issuecomment-512707723 retest this please This is