[GitHub] [spark] cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim

cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r349097413 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CastBenchmark.scala #

[GitHub] [spark] cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim

cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r349015970 ## File path: sql/core/src/test/resources/sql-tests/inputs/comparator.sql ## @@ -1,3 +1,12 @@ -- bi

[GitHub] [spark] cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim

cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r349015186 ## File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ## @@ -1077

[GitHub] [spark] cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim

cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r349013868 ## File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ## @@ -1077

[GitHub] [spark] cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim

cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r348961154 ## File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ## @@ -1077

[GitHub] [spark] cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim

cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r348961154 ## File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ## @@ -1077

[GitHub] [spark] cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim

cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r348944332 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CastBenchmark.scala #

[GitHub] [spark] cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim

cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r348922146 ## File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ## @@ -553,

[GitHub] [spark] cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim

cloud-fan commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r348921668 ## File path: sql/core/benchmarks/CastBenchmark-results.txt ## @@ -0,0 +1,12 @@ +===