cloud-fan commented on a change in pull request #27055: [SPARK-30394]Skip DetermineTableStats rule when hive table can be converted to datasource table URL: https://github.com/apache/spark/pull/27055#discussion_r373952868
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CatalogFileIndex.scala ########## @@ -61,6 +59,12 @@ class CatalogFileIndex( override def refresh(): Unit = fileStatusCache.invalidateAll() + override def sizeInBytes: Long = { + table.stats.map(_.sizeInBytes.toLong).getOrElse{ + filterPartitions(Nil).sizeInBytes Review comment: This is super expensive. Are you sure we always need to do it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org