cloud-fan commented on a change in pull request #29346: URL: https://github.com/apache/spark/pull/29346#discussion_r464818994
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/CachedBatchSerializerSuite.scala ########## @@ -120,6 +121,11 @@ class CachedBatchSerializerSuite extends QueryTest with SharedSparkSession { classOf[TestSingleIntColumnarCachedBatchSerializer].getName) } + protected override def afterAll(): Unit = { Review comment: let's do it in `beforeAll` as well, to guarantee that we are testing a fresh serializer in this test suite. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org