[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489187271 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Le

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489186794 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Le

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489185564 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Le

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r489185786 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -245,15 +245,24 @@ private[deploy] class Master( logError("Le

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-15 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r488601401 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -79,12 +79,23 @@ private[spark] class CoarseGraine

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r488058077 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -79,12 +79,23 @@ private[spark] class CoarseGraine

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r488056433 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -79,12 +79,23 @@ private[spark] class CoarseGraine

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487858334 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ## @@ -467,67 +467,42 @@ class CoarseGrainedSc

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487856488 ## File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala ## @@ -264,17 +253,21 @@ private[spark] class CoarseGrai

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487855223 ## File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala ## @@ -768,11 +768,14 @@ private[deploy] class Worker( } } - pr

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487853452 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -891,16 +896,13 @@ private[deploy] class Master( logInfo(s"Deco

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487853452 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -891,16 +896,13 @@ private[deploy] class Master( logInfo(s"Deco

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487853452 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -891,16 +896,13 @@ private[deploy] class Master( logInfo(s"Deco

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487849987 ## File path: core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ## @@ -94,8 +94,9 @@ private[spark] trait ExecutorAllocationClient {

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487778265 ## File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala ## @@ -70,7 +70,7 @@ private[deploy] class Worker( if (conf.get(config.

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487699399 ## File path: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala ## @@ -61,13 +61,28 @@ private[deploy] object DeployMessages { } /

[GitHub] [spark] cloud-fan commented on a change in pull request #29722: [SPARK-32850][CORE] Simplify the RPC message flow of decommission

2020-09-14 Thread GitBox
cloud-fan commented on a change in pull request #29722: URL: https://github.com/apache/spark/pull/29722#discussion_r487692255 ## File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala ## @@ -95,8 +95,13 @@ private[spark] object Coar