[GitHub] [spark] cloud-fan commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

cloud-fan commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r511928699 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1242,6 +1242,13 @@ object SQLConf { .booleanConf

[GitHub] [spark] cloud-fan commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

cloud-fan commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r511810245 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1052,12 +1052,18 @@ object CombineFilters exte

[GitHub] [spark] cloud-fan commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

cloud-fan commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r510659012 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/RemoveRedundantSortsSuite.scala ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apach

[GitHub] [spark] cloud-fan commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

cloud-fan commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r510658277 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/RemoveRedundantSortsSuite.scala ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apach

[GitHub] [spark] cloud-fan commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

cloud-fan commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r510658277 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/RemoveRedundantSortsSuite.scala ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apach

[GitHub] [spark] cloud-fan commented on a change in pull request #30093: [SPARK-33183][SQL] Fix EliminateSorts bug when removing global sorts

cloud-fan commented on a change in pull request #30093: URL: https://github.com/apache/spark/pull/30093#discussion_r509880688 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1052,11 +1052,11 @@ object CombineFilters exte