[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r520564463 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/HasConf.scala ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r520564738 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/HasConf.scala ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r520565272 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -42,7 +42,7 @@ import org.apache.spark.sql.cataly

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r520566520 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -61,34 +61,38 @@ class SessionCatalog(

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r520570072 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala ## @@ -188,27 +188,29 @@ class Boole

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r520570386 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala ## @@ -188,27 +188,29 @@ class Boole

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r520577201 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', '-MM-dd G');

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r520578390 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala ## @@ -60,8 +59,6 @@ case class HiveTableScanExec(

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r521251047 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', '-MM-dd G');

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r521545103 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -149,7 +149,7 @@ select to_timestamp('2019-10-06 A', '-MM-dd G');

[GitHub] [spark] cloud-fan commented on a change in pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

cloud-fan commented on a change in pull request #30299: URL: https://github.com/apache/spark/pull/30299#discussion_r523944573 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala ## @@ -172,7 +172,7 @@ case class HiveTableScanExec(