[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r531599042 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala ## @@ -945,6 +934,34 @@ abstract class AnsiCastSuit

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r530370757 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part3.sql.out ## @@ -71,7 +71,8 @@ insert into datetimes values -- !quer

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r530367654 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala ## @@ -945,6 +934,36 @@ abstract class AnsiCastSuit

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r530367089 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala ## @@ -945,6 +934,36 @@ abstract class AnsiCastSuit

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r530366120 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -1254,10 +1260,11 @@ abstract class CastBase exten

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r530365453 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -720,10 +720,12 @@ case class DateF

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r530364835 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -364,6 +364,15 @@ object DateTimeUtils { }

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r529621021 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -453,7 +453,8 @@ abstract class CastBase extends U

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r528567293 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ## @@ -1286,4 +1287,47 @@ class DateExpr

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r528565942 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ## @@ -1286,4 +1287,47 @@ class DateExpr

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r528559834 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -364,6 +364,15 @@ object DateTimeUtils { }

[GitHub] [spark] cloud-fan commented on a change in pull request #30442: [SPARK-33498][SQL] Datetime parsing should fail if the input string can't be parsed, or the pattern string is invalid

cloud-fan commented on a change in pull request #30442: URL: https://github.com/apache/spark/pull/30442#discussion_r528557886 ## File path: docs/sql-ref-ansi-compliance.md ## @@ -136,12 +136,17 @@ The behavior of some SQL functions can be different under ANSI mode (`spark.sql.