[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-03 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r535187274 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCNamespaceTest.scala ## @@ -0,0 +1,61 @@ +/* + * Licen

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533911399 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCNamespaceTest.scala ## @@ -0,0 +1,62 @@ +/* + * Licen

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533910906 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -171,6 +175,130 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533910609 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -171,6 +175,130 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533910326 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -171,6 +175,130 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533910169 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -171,6 +175,130 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533909747 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -171,6 +175,130 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533909303 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -171,6 +175,130 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533376591 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,133 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533375795 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,125 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r533375795 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,125 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-30 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r532430050 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,125 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-30 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r532429577 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,125 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-30 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r532429029 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,125 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-30 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r532426531 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,125 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-30 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r532425942 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,125 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30473: [SPARK-33430][SQL] Support namespaces in JDBC v2 Table Catalog

2020-11-24 Thread GitBox
cloud-fan commented on a change in pull request #30473: URL: https://github.com/apache/spark/pull/30473#discussion_r530068393 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -170,6 +174,125 @@ class JDBCTabl