[GitHub] [spark] cloud-fan commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r533645049 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala ## @@ -263,4 +263,19 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r533540575 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -48,6 +48,9 @@ object ConstantFolding

[GitHub] [spark] cloud-fan commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-12-01 Thread GitBox
cloud-fan commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r53699 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ## @@ -48,6 +48,9 @@ object ConstantFolding

[GitHub] [spark] cloud-fan commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-11-30 Thread GitBox
cloud-fan commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r532447405 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -873,24 +873,30 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-11-30 Thread GitBox
cloud-fan commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r531413098 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -873,24 +873,30 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-11-26 Thread GitBox
cloud-fan commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r531413076 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -873,24 +873,30 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #30504: [SPARK-33544][SQL] Optimizer should not insert filter when explode with CreateArray/CreateMap

2020-11-25 Thread GitBox
cloud-fan commented on a change in pull request #30504: URL: https://github.com/apache/spark/pull/30504#discussion_r530606734 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -873,24 +873,30 @@ object