[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-15 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r613890448 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ## @@ -58,6 +58,12 @@ class QueryExecution( val id: Long

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-09 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r610476090 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ## @@ -71,7 +72,26 @@ class QueryExecution( lazy val ana

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-09 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r610475691 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ## @@ -71,7 +72,26 @@ class QueryExecution( lazy val ana

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-07 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r608660949 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala ## @@ -64,9 +65,15 @@ private[hive] clas

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r607841363 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala ## @@ -64,9 +65,15 @@ private[hive] clas

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r607837639 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala ## @@ -64,9 +65,15 @@ private[hive] clas

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r607795536 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala ## @@ -64,9 +65,15 @@ private[hive] clas

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-06 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r607650297 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala ## @@ -64,9 +65,15 @@ private[hive] clas

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-05 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r607128500 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriverSuite.scala ## @@ -0,0 +1,65 @@ +/* + * License

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-05 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r607128286 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriverSuite.scala ## @@ -0,0 +1,65 @@ +/* + * License

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-05 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r607127489 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala ## @@ -49,11 +49,13 @@ object LocalRelation {

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-04-05 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r607127234 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -223,11 +223,16 @@ class Dataset[T] private[sql]( @transient private[s

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-03-31 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r604687761 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -223,11 +224,18 @@ class Dataset[T] private[sql]( @transient private[s

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-03-29 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r603434178 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -223,11 +224,18 @@ class Dataset[T] private[sql]( @transient private[s

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-03-29 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r603168384 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala ## @@ -64,9 +64,15 @@ private[hive] clas

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-03-29 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r603144714 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala ## @@ -64,9 +64,15 @@ private[hive] clas

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-03-29 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r603073246 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala ## @@ -64,9 +64,15 @@ private[hive] clas

[GitHub] [spark] cloud-fan commented on a change in pull request #31968: [SPARK-34873][SQL] Avoid wrapped in withNewExecutionId twice when run SQL with side effects

2021-03-29 Thread GitBox
cloud-fan commented on a change in pull request #31968: URL: https://github.com/apache/spark/pull/31968#discussion_r603071304 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -223,11 +224,18 @@ class Dataset[T] private[sql]( @transient private[s