[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r651629291 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala ## @@ -652,3 +652,15 @@ case object UnresolvedSeed ex

[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r650982808 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala ## @@ -652,3 +652,15 @@ case object UnresolvedSeed ex

[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r650981865 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -2457,164 +2451,133 @@ class Analyzer(override va

[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r649661183 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -2457,164 +2450,127 @@ class Analyzer(override va

[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r649223245 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -839,9 +839,7 @@ trait CheckAnalysis extends

[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [SPARK-35712][SQL] Simplify ResolveAggregateFunctions

cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r649223245 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -839,9 +839,7 @@ trait CheckAnalysis extends