[GitHub] [spark] cloud-fan commented on a change in pull request #32885: [SPARK-35742][SQL] Expression.semanticEquals should be symmetrical

cloud-fan commented on a change in pull request #32885: URL: https://github.com/apache/spark/pull/32885#discussion_r650141027 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala ## @@ -76,13 +76,6 @@ abstract class SubqueryExpress

[GitHub] [spark] cloud-fan commented on a change in pull request #32885: [SPARK-35742][SQL] Expression.semanticEquals should be symmetrical

cloud-fan commented on a change in pull request #32885: URL: https://github.com/apache/spark/pull/32885#discussion_r651019687 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -73,7 +73,9 @@ case class HashAggregateExe

[GitHub] [spark] cloud-fan commented on a change in pull request #32885: [SPARK-35742][SQL] Expression.semanticEquals should be symmetrical

cloud-fan commented on a change in pull request #32885: URL: https://github.com/apache/spark/pull/32885#discussion_r651020692 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -73,7 +73,9 @@ case class HashAggregateExe

[GitHub] [spark] cloud-fan commented on a change in pull request #32885: [SPARK-35742][SQL] Expression.semanticEquals should be symmetrical

cloud-fan commented on a change in pull request #32885: URL: https://github.com/apache/spark/pull/32885#discussion_r651409123 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q23b/simplified.txt ## @@ -188,22 +188,6 @@ TakeOrderedAndProject [c

[GitHub] [spark] cloud-fan commented on a change in pull request #32885: [SPARK-35742][SQL] Expression.semanticEquals should be symmetrical

cloud-fan commented on a change in pull request #32885: URL: https://github.com/apache/spark/pull/32885#discussion_r651669404 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -73,7 +73,9 @@ case class HashAggregateExe

[GitHub] [spark] cloud-fan commented on a change in pull request #32885: [SPARK-35742][SQL] Expression.semanticEquals should be symmetrical

cloud-fan commented on a change in pull request #32885: URL: https://github.com/apache/spark/pull/32885#discussion_r652023192 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -73,7 +73,9 @@ case class HashAggregateExe