[GitHub] [spark] cloud-fan commented on a diff in pull request #36608: [SPARK-39230][SQL] Support ANSI Aggregate Function: regr_slope

cloud-fan commented on code in PR #36608: URL: https://github.com/apache/spark/pull/36608#discussion_r883219417 ## sql/core/src/test/resources/sql-tests/inputs/linear-regression.sql: ## @@ -0,0 +1,51 @@ +-- Test aggregate operator with codegen on and off. Review Comment: We

[GitHub] [spark] cloud-fan commented on a diff in pull request #36608: [SPARK-39230][SQL] Support ANSI Aggregate Function: regr_slope

cloud-fan commented on code in PR #36608: URL: https://github.com/apache/spark/pull/36608#discussion_r882396518 ## sql/core/src/test/resources/sql-tests/results/group-by.sql.out: ## @@ -1071,6 +1071,39 @@ struct 2 200.0 +-- !query +SELECT regr_slope(y, x) FROM

[GitHub] [spark] cloud-fan commented on a diff in pull request #36608: [SPARK-39230][SQL] Support ANSI Aggregate Function: regr_slope

cloud-fan commented on code in PR #36608: URL: https://github.com/apache/spark/pull/36608#discussion_r877763059 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala: ## @@ -34,7 +34,7 @@ abstract class Covariance(val left:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36608: [SPARK-39230][SQL] Support ANSI Aggregate Function: regr_slope

cloud-fan commented on code in PR #36608: URL: https://github.com/apache/spark/pull/36608#discussion_r877745569 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala: ## @@ -69,7 +69,7 @@ abstract class Covariance(val left: