[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r913430428 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -1026,18 +1034,93 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r913359517 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -1026,14 +1034,85 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r913359294 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -344,6 +344,59 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r913359202 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -344,6 +344,59 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r912073385 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -202,7 +209,7 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r912071434 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -344,6 +344,57 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911805738 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -1026,14 +1034,70 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911805060 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -1026,14 +1034,70 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911803758 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala: ## @@ -270,6 +270,17 @@ abstract class JdbcDialect extends Serializable with Logging{

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911802407 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -38,7 +40,9 @@ private[sql] object H2Dialect extends JdbcDialect { Set("ABS",

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911801946 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -344,6 +344,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911801086 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -344,6 +344,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911800754 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -327,4 +334,13 @@ protected String visitTrim(String direction,

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911800128 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Extract.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911798925 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Extract.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911797821 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Extract.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911584417 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -344,6 +344,51 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r911583956 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -290,4 +297,15 @@ protected String visitTrim(String direction,

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910687319 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -123,4 +127,26 @@ private[sql] object H2Dialect extends JdbcDialect { }

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910686772 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -290,4 +297,15 @@ protected String visitTrim(String direction,

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910685251 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Extract.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r910683281 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Extract.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r908137438 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -254,6 +254,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r907164502 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -254,6 +254,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r905938389 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -254,6 +254,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r905937667 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -254,6 +254,55 @@ class V2ExpressionBuilder(e: Expression, isPredicate:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r905936600 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Extract.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r905936364 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Extract.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r903241878 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -262,6 +262,55 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r903241123 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,30 @@ *Since version: 3.4.0 * *

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r902350436 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,90 @@ *Since version: 3.4.0 * *

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r902350436 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,90 @@ *Since version: 3.4.0 * *

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r893163447 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,90 @@ *Since version: 3.4.0 * *

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r893067774 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,90 @@ *Since version: 3.4.0 * *

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r893067221 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -259,6 +259,55 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r890188771 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -259,6 +259,55 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r882456701 ## sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala: ## @@ -103,6 +103,14 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r882418668 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -196,6 +196,96 @@ *Since version: 3.4.0 * *

[GitHub] [spark] cloud-fan commented on a diff in pull request #36663: [SPARK-38899][SQL]DS V2 supports push down datetime functions

cloud-fan commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r882407577 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -263,4 +280,8 @@ protected String visitTrim(String direction,