[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r892541582 ## core/src/main/scala/org/apache/spark/SparkException.scala: ## @@ -73,236 +101,340 @@ private[spark] case class ExecutorDeadException(message: String) */ private

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r892535272 ## core/src/main/scala/org/apache/spark/ErrorInfo.scala: ## @@ -73,18 +73,20 @@ private[spark] object SparkThrowableHelper { def getMessage( errorClass: St

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891320687 ## sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala: ## @@ -36,13 +36,31 @@ class AnalysisException protected[sql] ( @transient val plan:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891314795 ## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ## @@ -264,6 +264,87 @@ abstract class SparkFunSuite } } + /** + * Checks an exception with a

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891312375 ## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ## @@ -264,6 +264,87 @@ abstract class SparkFunSuite } } + /** + * Checks an exception with a

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891311339 ## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ## @@ -264,6 +264,87 @@ abstract class SparkFunSuite } } + /** + * Checks an exception with a

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891309492 ## core/src/test/scala/org/apache/spark/SparkFunSuite.scala: ## @@ -264,6 +264,87 @@ abstract class SparkFunSuite } } + /** + * Checks an exception with a

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891302240 ## core/src/main/scala/org/apache/spark/ErrorInfo.scala: ## @@ -98,6 +100,29 @@ private[spark] object SparkThrowableHelper { s"[$displayClass] $displayMessage$dis

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891301726 ## core/src/main/scala/org/apache/spark/ErrorInfo.scala: ## @@ -73,18 +73,20 @@ private[spark] object SparkThrowableHelper { def getMessage( errorClass: St

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891304223 ## core/src/main/scala/org/apache/spark/ErrorInfo.scala: ## @@ -73,18 +73,20 @@ private[spark] object SparkThrowableHelper { def getMessage( errorClass: St

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891302240 ## core/src/main/scala/org/apache/spark/ErrorInfo.scala: ## @@ -98,6 +100,29 @@ private[spark] object SparkThrowableHelper { s"[$displayClass] $displayMessage$dis

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891301726 ## core/src/main/scala/org/apache/spark/ErrorInfo.scala: ## @@ -73,18 +73,20 @@ private[spark] object SparkThrowableHelper { def getMessage( errorClass: St

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891297431 ## core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java: ## @@ -39,11 +39,17 @@ public SparkOutOfMemoryError(OutOfMemoryError e) { } publi

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891293373 ## core/src/main/resources/error/error-classes.json: ## @@ -333,7 +332,7 @@ }, "SECOND_FUNCTION_ARGUMENT_NOT_INTEGER" : { "message" : [ - "The second a

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891292604 ## core/src/main/resources/error/error-classes.json: ## @@ -157,8 +157,7 @@ "See more details in SPARK-31404. You can set the SQL config or", "

[GitHub] [spark] cloud-fan commented on a diff in pull request #36693: [SPARK-39349] Add a centralized CheckError method for QA of error path

cloud-fan commented on code in PR #36693: URL: https://github.com/apache/spark/pull/36693#discussion_r891290994 ## core/src/main/java/org/apache/spark/SparkThrowable.java: ## @@ -36,6 +36,10 @@ public interface SparkThrowable { // If null, error class is not set String get