[GitHub] [spark] cloud-fan commented on a diff in pull request #36871: [SPARK-39469][SQL] Infer date type for CSV schema inference

2022-07-22 Thread GitBox
cloud-fan commented on code in PR #36871: URL: https://github.com/apache/spark/pull/36871#discussion_r927358619 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala: ## @@ -197,34 +198,46 @@ class UnivocityParser(

[GitHub] [spark] cloud-fan commented on a diff in pull request #36871: [SPARK-39469][SQL] Infer date type for CSV schema inference

2022-07-13 Thread GitBox
cloud-fan commented on code in PR #36871: URL: https://github.com/apache/spark/pull/36871#discussion_r920177503 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala: ## @@ -148,7 +148,28 @@ class CSVOptions( // A language tag in IETF BCP 47

[GitHub] [spark] cloud-fan commented on a diff in pull request #36871: [SPARK-39469][SQL] Infer date type for CSV schema inference

2022-07-11 Thread GitBox
cloud-fan commented on code in PR #36871: URL: https://github.com/apache/spark/pull/36871#discussion_r918484209 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala: ## @@ -148,7 +148,28 @@ class CSVOptions( // A language tag in IETF BCP 47

[GitHub] [spark] cloud-fan commented on a diff in pull request #36871: [SPARK-39469][SQL] Infer date type for CSV schema inference

2022-07-08 Thread GitBox
cloud-fan commented on code in PR #36871: URL: https://github.com/apache/spark/pull/36871#discussion_r916523583 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala: ## @@ -148,7 +148,28 @@ class CSVOptions( // A language tag in IETF BCP 47

[GitHub] [spark] cloud-fan commented on a diff in pull request #36871: [SPARK-39469][SQL] Infer date type for CSV schema inference

2022-07-08 Thread GitBox
cloud-fan commented on code in PR #36871: URL: https://github.com/apache/spark/pull/36871#discussion_r916522350 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala: ## @@ -117,7 +123,10 @@ class CSVInferSchema(val options: CSVOptions) extends