cloud-fan commented on code in PR #37074:
URL: https://github.com/apache/spark/pull/37074#discussion_r918091135
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala:
##########
@@ -72,12 +72,22 @@ object RewritePredicateSubquery extends Rule[LogicalPlan]
with PredicateHelper {
val outerRefs = outerPlan.outputSet ++ outerReferences
val duplicates = outerRefs.intersect(subplan.outputSet)
if (duplicates.nonEmpty) {
- condition.foreach { e =>
+ def throwOnConflictingAttrs(attrs: AttributeSet): Unit = {
Review Comment:
```suggestion
def failForConflictingAttrs(attrs: AttributeSet): Unit = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
