[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1206312754 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -3957,51 +4023,66 @@ class AstBuilder extends SqlBaseParserBaseVisitor[An

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1206313872 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4545,28 +4672,32 @@ class AstBuilder extends SqlBaseParserBaseVisitor[An

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1206312398 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -2644,42 +2688,63 @@ class AstBuilder extends SqlBaseParserBaseVisitor[An

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1206312142 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -2644,42 +2688,63 @@ class AstBuilder extends SqlBaseParserBaseVisitor[An

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1206311136 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -2111,6 +2143,15 @@ class AstBuilder extends SqlBaseParserBaseVisitor[Any

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1206308471 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -1114,6 +1114,9 @@ class Analyzer(override val catalogManager: CatalogMan

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1206308036 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala: ## @@ -127,23 +127,24 @@ case class UnresolvedFunctionName( comman

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1205505201 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -3465,10 +3534,12 @@ class AstBuilder extends SqlBaseParserBaseVisitor[An

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1205502065 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -2130,8 +2176,11 @@ class AstBuilder extends SqlBaseParserBaseVisitor[Any

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1205499405 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -402,12 +433,14 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRe

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1205484829 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -2130,8 +2176,11 @@ class AstBuilder extends SqlBaseParserBaseVisitor[Any

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1205315208 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala: ## @@ -36,6 +36,8 @@ class ResolveCatalogs(val catalogManager: CatalogMan

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1204478567 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala: ## @@ -276,6 +315,99 @@ object UnresolvedAttribute { } } +/** + * Holds

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1204476135 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -1492,16 +1520,31 @@ class AstBuilder extends SqlBaseParserBaseVisitor[An

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1204441335 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -402,101 +424,104 @@ class AstBuilder extends SqlBaseParserBaseVisitor[An

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1204438459 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -272,27 +282,33 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRe

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1204434077 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala: ## @@ -36,6 +36,18 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMa

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1204434077 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala: ## @@ -36,6 +36,18 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMa

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1204434077 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala: ## @@ -36,6 +36,18 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMa

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r120442 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/IdentifierClauseUtil.scala: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1198584893 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -368,7 +369,7 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef]

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1198426047 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -368,7 +369,7 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef]

[GitHub] [spark] cloud-fan commented on a diff in pull request #41007: [SPARK-43205] IDENTIFIER clause

cloud-fan commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1197357196 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -368,7 +369,7 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef]