[GitHub] [spark] cloud-fan commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-08-05 Thread GitBox
cloud-fan commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-518188378 A late LGTM This is an automated message from the Apache Git Service.

[GitHub] [spark] cloud-fan commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-07-25 Thread GitBox
cloud-fan commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-515003977 generally looks good. Tow comments: 1. Shall we add `String[] defaultNamespace` as we discussed in the community sync? 2. Shall

[GitHub] [spark] cloud-fan commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-07-24 Thread GitBox
cloud-fan commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-514846978 retest this please This is an automated message from the Apache Git

[GitHub] [spark] cloud-fan commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-05-08 Thread GitBox
cloud-fan commented on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-490728914 I feel separating creating and listing namespaces may make the API too complicated. I think it's OK if some implementation throws an