cloud-fan commented on issue #25104: [SPARK-28341][SQL] create a public API for
V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#issuecomment-530467238
We can do it if `V2SessionCatalog` doesn't refer to anything in sql/core.
cloud-fan commented on issue #25104: [SPARK-28341][SQL] create a public API for
V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#issuecomment-529483079
BTW, `V2SessionCatalog` is in the `execution` package, which is meant to be
private, like the `catalyst` package.
cloud-fan commented on issue #25104: [SPARK-28341][SQL] create a public API for
V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#issuecomment-529468332
thanks for the review, merging to master!
This is an
cloud-fan commented on issue #25104: [SPARK-28341][SQL] create a public API for
V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#issuecomment-529329167
retest this please
This is an automated message from the
cloud-fan commented on issue #25104: [SPARK-28341][SQL] create a public API for
V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#issuecomment-529295990
If `V2SessionCatalog` implements `StagingTableCatalog` one day, it should
still call `createTable`, `dropTable`, etc.
cloud-fan commented on issue #25104: [SPARK-28341][SQL] create a public API for
V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#issuecomment-528872704
retest this please
This is an automated message from the
cloud-fan commented on issue #25104: [SPARK-28341][SQL] create a public API for
V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#issuecomment-52939
retest this please
This is an automated message from the
cloud-fan commented on issue #25104: [SPARK-28341][SQL] create a public API for
V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#issuecomment-527031645
retest it please
This is an automated message from the
cloud-fan commented on issue #25104: [SPARK-28341][SQL] create a public API for
V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#issuecomment-526523320
@rdblue thanks for your review! I've addressed your comments and please take
another look when you have time. Thanks!