[GitHub] [spark] cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2020-01-31 Thread GitBox
cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-580678470 done in https://github.com/apache/spark/pull/27417 T

[GitHub] [spark] cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2020-01-22 Thread GitBox
cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-577506512 I'm fine to backport. I'm on vacation soon, can someone help to backport? ---

[GitHub] [spark] cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2020-01-22 Thread GitBox
cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-577482122 This is not a complete fix but fail the query if we are not able to resolve the ambiguity. Is it OK to backport? It c

[GitHub] [spark] cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2019-08-05 Thread GitBox
cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-518467378 thanks, merging to master! This is an automated mess

[GitHub] [spark] cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2019-08-05 Thread GitBox
cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-518187776 retest this please This is an automated message from

[GitHub] [spark] cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2019-07-31 Thread GitBox
cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-516913929 `df("a.b")` is different from things like `df("a") + 1`, because we need to take care of `df("a.b")` to attach the da

[GitHub] [spark] cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2019-07-31 Thread GitBox
cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-516832525 The ambiguity comes from `AttributeReference`s with the same expr ID. The nested column in Spark is just an expressio

[GitHub] [spark] cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2019-07-24 Thread GitBox
cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-514548312 retest this please This is an automated message from

[GitHub] [spark] cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2019-07-11 Thread GitBox
cloud-fan commented on issue #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#issuecomment-510365577 retest this please This is an automated message from