[GitHub] [spark] cloud-fan commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

2019-09-12 Thread GitBox
cloud-fan commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-530824963 LGTM, cc @rednaxelafx to take another look

[GitHub] [spark] cloud-fan commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

2019-09-10 Thread GitBox
cloud-fan commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529919109 LGTM. As usual, can we have a simple microbenchmark to show the advantage? I saw